Perform file roll only occasionally when file is locked#3684
Merged
Evangelink merged 1 commit intomicrosoft:mainfrom May 30, 2022
Merged
Perform file roll only occasionally when file is locked#3684Evangelink merged 1 commit intomicrosoft:mainfrom
Evangelink merged 1 commit intomicrosoft:mainfrom
Conversation
Evangelink
reviewed
May 26, 2022
Member
Evangelink
left a comment
Evangelink
left a comment
There was a problem hiding this comment.
What happens to the traces performed in between the rolling?
Could we use something mockable instead of Stopwatch and add some tests for this behavior?
Member
Author
|
Nothing happens to them, they will continue being written into the file, same as they did before. We just don't attempt to move the file on every line we write, and bring performance to halt. Feel free to be the other person in your "we" and add as many unit tests as you want 😁 |
Evangelink
approved these changes
May 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the log file becomes bigger than the roll limit and is opened in editor it becomes locked, and we try to move it twice on every message. This avoids rolling it for 1 minute since we last tried and failed.
Related issue
Fix #3413